Hi @shalberd. Thanks for your PR.

I'm waiting for a opendatahub-io member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

/retest

@jiridanek @jstourac @guimou tested with built image quay.io/opendatahub/workbench-images:rstudio-c9s-python-3.9-pr-798

again showing old image behavior vs new pr-797 behavior:

Knit to PDF button:

Render process leads to error:

processing file: Test2.Rmd                                                                                            
/usr/lib/rstudio-server/bin/quarto/bin/tools/pandoc +RTS -K512m -RTS Test2.knit.md --to latex --from markdown+autolink_bare_uris+tex_math_single_backslash --output Test2.tex --lua-filter /opt/app-root/src/Rpackages/4.3/rmarkdown/rmarkdown/lua/pagebreak.lua --lua-filter /opt/app-root/src/Rpackages/4.3/rmarkdown/rmarkdown/lua/latex-div.lua --embed-resources --standalone --highlight-style tango --pdf-engine pdflatex --variable graphics --variable 'geometry:margin=1in'

output file: Test2.knit.md

! LaTeX Error: File `framed.sty' not found.

! Emergency stop.
<read *>
Error: LaTeX failed to compile Test2.tex. See https://yihui.org/tinytex/r/#debugging for debugging tips. See Test2.log for more info.

changed workbench image to quay.io/opendatahub/workbench-images:rstudio-c9s-python-3.9-pr-798`

Testing with markdown to PDF no longer leads to error, rendering fine.

Hi @atheo89
moved package install to different section, see code change.

image built at e.g. quay.io/opendatahub/workbench-images:rstudio-c9s-python-3.9-pr-798

I do not have time to test it again as I did described in this thread last week, but should be good, right?

/retest

@atheo89 @jiridanek I see, python 3.9 R Studio removed from main ... I rebased, concept stays :-)

Hi @shalberd I just reviewed this work. Everything looks good 🙂
Test the image with the changes that made yesterday and I’m getting the same results as you.

Thank you for fixing this!

/lgtm

@atheo89 all good except those offbeat / flaky tests CICD

/retest-required

@shalberd: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Full PR test history. Your PR dashboard.

/override ci/prow/rstudio-notebook-e2e-tests
/override ci/prow/images

@jiridanek: Overrode contexts on behalf of jiridanek: ci/prow/images, ci/prow/rstudio-notebook-e2e-tests

/lgtm
/approve
thanks +💯

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jiridanek

The full list of commands accepted by this bot can be found here.

The pull request process is described here